Building a custom rviz display

[DLu]

I hate RST.

[DLu]

Review please?

[DLu]

@clalancette ? @audrow ? Any movement?

[clalancette]

Sorry I never looked back at this.

I think this would be a good tutorial to have, but I also think it belongs in a series with other RViz changes. I'm going to hold off on looking at this one until we land #4040 , at which point this will have a natural place to slot into.

[clalancette]

OK, we've now landed #4040. So I'm going to suggest that this gets moved into a tutorial under the new Tutorials/Intermediate/RViz directory.

[DLu]

Rebased, and moved to the new RViz folder, and I even changed things up to follow the same directory structure as the existing tutorial in that folder.

[ahcorde]

do you mind to use include guards? as we are doing on RViz ?

If you are using the common linters probaby it will require this

#ifndef BLAH_H
#define BLAH_H

#endif  // BLAH_H

[DLu]

I was going to argue with you about using modern standards, but then I dug and found this bit of the Google guide.

That's not going to stop me from posting a gif that came to mind.

(I'm not calling this a stupid decision, because upon further research, pragma is generally supported but is not official lore)

[ahcorde]

Thank you sir!

[clalancette]

Overall, this is great. Thanks for moving it around.

I left a bunch of stuff to cleanup.

[DLu]

I will update the code style if you can provide a .clang-format file that is to be used canonically for tutorials.

I find this process frustrating, to have a PR sit untouched for a year, then get held up in the end for the placement of curly braces. This seems like perfect is the enemy of the good. If you want to do something to increase the number of community generated tutorials, you need to lower the bar a little.

[clalancette]

I will update the code style if you can provide a .clang-format file that is to be used canonically for tutorials.

Unfortunately, that is impossible; clang-format can't be configured to follow our coding style currently.

[clalancette]

Unfortunately, that is impossible; clang-format can't be configured to follow our coding style currently.

Sorry, that was a little terse. We can't do clang-format, but the right solution here is to enable uncrustify on the end repository, and then fix all of the uncrustify problems. That will then conform to the style that we want. I'm willing to do that work if the rviz_plugin_tutorial repository is available somewhere (that's a blocking issue anyway).

[clalancette]

Sorry, that was a little terse. We can't do clang-format, but the right solution here is to enable uncrustify on the end repository, and then fix all of the uncrustify problems. That will then conform to the style that we want. I'm willing to do that work if the rviz_plugin_tutorial repository is available somewhere (that's a blocking issue anyway).

All right, see MetroRobots/rviz_plugin_tutorial#1

[clalancette]

Thanks for sticking with this one. I've left a few more grammatical/layout things to change, but this is looking close.

[clalancette]

This is great. Thanks @DLu for sticking with this. I'm going to go ahead and merge this in, and also backport to iron and humble.

[clalancette]

@Mergifyio backport humble iron

[mergify]

backport humble iron

✅ Backports have been created

• #4285 Building a custom rviz display (backport #3384) has been created for branch humble
• #4286 Building a custom rviz display (backport #3384) has been created for branch iron