Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--start-offset as non-negative float (relax equality to allow 0 as input) #1891

Open
23pointsNorth opened this issue Dec 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@23pointsNorth
Copy link

Description

Currently, based on #931, the input cli param --start-offset has a default value of 0.0, yet is of type check_positive_float .

This creates the issue, that by default, the value is 0, yet one cannot set the value to 0 by not using hte default field. i.e.

ros2 bag run {bag_name} --start-offset 0 # this fails
ros2 bag run {bag_name}  # this works as expected, yet starts from 0

Completion Criteria

It would be great to relax the equality, as it would allow using the start-offset param as part of matrix scans in CI jobs and other places where a list of offsets may be chosen.

P.S. check_positive_float and positive_float have been used mixed within the argparse.

@23pointsNorth 23pointsNorth added the enhancement New feature or request label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant