Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for WString across all generators #352

Closed
dirk-thomas opened this issue Mar 12, 2019 · 3 comments
Closed

support for WString across all generators #352

dirk-thomas opened this issue Mar 12, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dirk-thomas
Copy link
Member

Follow up of #346.

@dirk-thomas
Copy link
Member Author

dirk-thomas commented May 2, 2019

@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 2, 2019
@jacobperron
Copy link
Member

Looks like you've addressed all the warnings/failures. Considering you are adding more work on top of this, we can merge as-is and catch anything we missed in the next round of CI.

@dirk-thomas
Copy link
Member Author

dirk-thomas commented May 2, 2019

I went over all PRs again and resolved the remaining comments. In favor of time I will merge the changes now and trigger a set of CI builds afterwards to double check. 🤞

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (aborted due to CI congestion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants