From 104f3e0ecc2bc4c3584fa0a38f34e236b4d229be Mon Sep 17 00:00:00 2001 From: Chris Lalancette Date: Thu, 31 Oct 2024 18:54:51 +0000 Subject: [PATCH 1/2] Add test_xmllint to rosidl_pycommon. It is one of the tests that it is currently missing, and will validate if the package.xml is bad for some reason. Signed-off-by: Chris Lalancette --- rosidl_pycommon/test/test_xmllint.py | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 rosidl_pycommon/test/test_xmllint.py diff --git a/rosidl_pycommon/test/test_xmllint.py b/rosidl_pycommon/test/test_xmllint.py new file mode 100644 index 000000000..08bf7fd78 --- /dev/null +++ b/rosidl_pycommon/test/test_xmllint.py @@ -0,0 +1,23 @@ +# Copyright 2019 Open Source Robotics Foundation, Inc. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from ament_xmllint.main import main +import pytest + + +@pytest.mark.linter +@pytest.mark.xmllint +def test_xmllint() -> None: + rc = main(argv=[]) + assert rc == 0, 'Found errors' From 83556995e1a39fc911b3edc218c68764b2965d98 Mon Sep 17 00:00:00 2001 From: Chris Lalancette Date: Thu, 31 Oct 2024 19:08:38 +0000 Subject: [PATCH 2/2] Feedback from review. Signed-off-by: Chris Lalancette --- rosidl_pycommon/package.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/rosidl_pycommon/package.xml b/rosidl_pycommon/package.xml index d63cb3751..83a9cbd11 100644 --- a/rosidl_pycommon/package.xml +++ b/rosidl_pycommon/package.xml @@ -21,6 +21,7 @@ ament_flake8 ament_pep257 ament_mypy + ament_xmllint python3-pytest