From ad6769f04b3c1acb54bf4606977154d551bed217 Mon Sep 17 00:00:00 2001
From: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
Date: Fri, 14 Jul 2023 18:23:23 -0400
Subject: [PATCH 1/3] Fix: Missing dependency that causes cmake error in
 downstream (resolves https://github.com/ros2/rosidl_python/issues/198)

Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
---
 rosidl_generator_py/package.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/rosidl_generator_py/package.xml b/rosidl_generator_py/package.xml
index 89e69c94..0f52e514 100644
--- a/rosidl_generator_py/package.xml
+++ b/rosidl_generator_py/package.xml
@@ -29,6 +29,8 @@
   <buildtool_export_depend>rosidl_typesupport_c</buildtool_export_depend>
   <buildtool_export_depend>rosidl_typesupport_interface</buildtool_export_depend>
 
+  <exec_depend>ament_cmake_flake8</exec_depend>
+  <exec_depend>ament_cmake_pep257</exec_depend>
   <exec_depend>ament_index_python</exec_depend>
   <exec_depend>python3-numpy</exec_depend>
   <exec_depend>rosidl_cli</exec_depend>

From 79ffe3378bf8a5c6cc49c9b6c71ca7f24e087d81 Mon Sep 17 00:00:00 2001
From: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
Date: Tue, 18 Jul 2023 15:28:22 -0400
Subject: [PATCH 2/3] Improve: Move the missing deps to test_depend (response
 to review comment
 https://github.com/ros2/rosidl_python/pull/199#discussion_r1265385346)

Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
---
 rosidl_generator_py/package.xml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/rosidl_generator_py/package.xml b/rosidl_generator_py/package.xml
index 0f52e514..397371a0 100644
--- a/rosidl_generator_py/package.xml
+++ b/rosidl_generator_py/package.xml
@@ -29,8 +29,16 @@
   <buildtool_export_depend>rosidl_typesupport_c</buildtool_export_depend>
   <buildtool_export_depend>rosidl_typesupport_interface</buildtool_export_depend>
 
+  <!-- BEGIN: Following 'exec_depend's are likely only needed in test in downstream,
+       so ideally "test_export_depend" (similar to 'build_export_depend') are reasonable.
+       With such a feature unexistent yet, they are 'exec_depend'-ed.
+       See https://github.com/ros2/rosidl_python/pull/199 -->
+  <exec_depend>ament_cmake_cppcheck</exec_depend>
+  <exec_depend>ament_cmake_cpplint</exec_depend>
   <exec_depend>ament_cmake_flake8</exec_depend>
   <exec_depend>ament_cmake_pep257</exec_depend>
+  <exec_depend>ament_cmake_uncrustify</exec_depend>
+  <!-- END -->  
   <exec_depend>ament_index_python</exec_depend>
   <exec_depend>python3-numpy</exec_depend>
   <exec_depend>rosidl_cli</exec_depend>

From 195a61889df51d167ba049044c984a4b0e70eecc Mon Sep 17 00:00:00 2001
From: Isaac Saito <130s@users.noreply.github.com>
Date: Thu, 3 Aug 2023 11:55:14 -0400
Subject: [PATCH 3/3] Reviewer's suggestion applied to
 rosidl_generator_py/package.xml

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
---
 rosidl_generator_py/package.xml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/rosidl_generator_py/package.xml b/rosidl_generator_py/package.xml
index 397371a0..49c970ac 100644
--- a/rosidl_generator_py/package.xml
+++ b/rosidl_generator_py/package.xml
@@ -29,16 +29,16 @@
   <buildtool_export_depend>rosidl_typesupport_c</buildtool_export_depend>
   <buildtool_export_depend>rosidl_typesupport_interface</buildtool_export_depend>
 
-  <!-- BEGIN: Following 'exec_depend's are likely only needed in test in downstream,
-       so ideally "test_export_depend" (similar to 'build_export_depend') are reasonable.
-       With such a feature unexistent yet, they are 'exec_depend'-ed.
+  <!-- TODO: The following 'exec_depend's are only needed in downstream tests,
+       so ideally a 'test_export_depend' (similar to 'build_export_depend') would be used.
+       Since that feature doesn't exist yet, they are 'exec_depend'-ed.
        See https://github.com/ros2/rosidl_python/pull/199 -->
   <exec_depend>ament_cmake_cppcheck</exec_depend>
   <exec_depend>ament_cmake_cpplint</exec_depend>
   <exec_depend>ament_cmake_flake8</exec_depend>
   <exec_depend>ament_cmake_pep257</exec_depend>
   <exec_depend>ament_cmake_uncrustify</exec_depend>
-  <!-- END -->  
+
   <exec_depend>ament_index_python</exec_depend>
   <exec_depend>python3-numpy</exec_depend>
   <exec_depend>rosidl_cli</exec_depend>