Add PNG file extension

[ghost]

Fixes #9

[ghost]

Additionally, as screenshots captured in PNG why there image/jpeg MIME-Type used in few places?

• screenshot-sharer/app/src/main/java/com/tomer/screenshotsharer/AssistLoggerSession.kt

  Line 100 in 6b57f7a

  put(MediaStore.MediaColumns.MIME_TYPE, "image/jpeg")

• screenshot-sharer/app/src/main/java/com/tomer/screenshotsharer/AssistLoggerSession.kt

  Line 156 in 6b57f7a

  shareIntent.type = "image/jpeg"

[rosenpin]

Thanks for the PR :)

This doesn't seem right.
On my device (Android 11) the screenshots are saved correctly as jpeg.
Your PR would change the name of the screenshot, I didn't test it but on Android Q+ it might result in jpeg images called "screenshot-.....png.jpg"
Please test it on an Android 11 emulator and let me know if I'm wrong.
Alternatively, only apply your solution to old Android versions (Q- not included)

[ghost]

I'm not be able to run any emulator.

On my device (Android 11) the screenshots are saved correctly as jpeg

But how, as app capture as PNG? Does on Android 11 it saves to folder it as JPEG? (actually on my Android 6 screenshots saves into "Pictures > Screenshots" are exactly PNG as I see in image quality & in file headers via Hex-editors)

• https://github.com/rosenpin/screenshot-sharer/blob/master/app/src/main/java/com/tomer/screenshotsharer/AssistLoggerSession.kt#L92-L118

BTW, As I see in "Screenshot Assistant" app (which is designed to store only JPEG screenshots) it uses Screenshot-${currentDateString()}.${imageFormat.fileExtension} for adding file extension.

• https://github.com/beatbrot/ScreenshotAssistant/blob/3d8ce0dc0e2580a6ba55d3379654b67ad79d9112/app/src/main/java/de/beatbrot/screenshotassistant/ScreenshotActivityViewModel.kt#L71
• Images always come out as JPEGs internally beatbrot/ScreenshotAssistant#75

[rosenpin]

Thanks for the detailed response.
Seems like you're right

I'm not sure because I really don't remember a whole lot from this project, but I assume this line should be changed:

screenshot-sharer/app/src/main/java/com/tomer/screenshotsharer/AssistLoggerSession.kt

Line 100 in 6b57f7a

put(MediaStore.MediaColumns.MIME_TYPE, "image/jpeg")

And potentially also this:

screenshot-sharer/app/src/main/java/com/tomer/screenshotsharer/AssistLoggerSession.kt

Line 156 in 6b57f7a

shareIntent.type = "image/jpeg"

Otherwise I really don't know where the .jpg suffix appear on my device

[ghost]

Thanks! May you add also app-release.apk asset to 2.0 release?
Can't wait to test! (F-Droid packaging is slow)

[rosenpin]

Actually I lost the keystore for this app, that's the reason the play store version is outdated by the way.
I'll upload an unsigned version of the app

[rosenpin]

https://github.com/rosenpin/screenshot-sharer/releases/download/2.1/app-debug.apk