Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BottomBar resize when change visibility of BottomBarTab to GONE #520

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

arturgaleno
Copy link

As discussed at #437 No more dynamic adding of tabs?.

Was suggestioned this piece of code:
bottomBar.getTabAtPosition(x).setVisibility(View.GONE);
to make tab gone dynamically.

But, when we use that, tabs don't get resized on BottomBar.

This PR comes to solve this issue and added this enhancement.

Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 54.902% when pulling dd90a98 on arturgaleno:master into 3118116 on roughike:master.

@yombunker
Copy link
Collaborator

@arturgaleno is this still a thing on the latest version?

@arturgaleno
Copy link
Author

@yombunker I really don't know. But, it's very simple to reproduce that behavior. Simple create a bottom bar with xml and then set any tab to gone. The bottom bar must resize it's content appropriately.

@yombunker
Copy link
Collaborator

@arturgaleno i don't think this is how is supposed to be done, i'm pretty sure you are suppose to change the items send to the BottomBar instead of making it "gone" programmatically and expecting to resize. @roughike can you chime on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants