-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added lighlight methods without triggering listener #770
base: master
Are you sure you want to change the base?
Conversation
@echan0524 what are you trying to achieve with this? if is just changing the icon in some way you can get the same by using selector state and setting something in the tab |
@yombunker It might be easier to understand the if I rename the methods to "selectOnlyWithId()" and "selectOnlyAtPosition" or something similar. I just found another PR which is trying to achieve the same goal. |
@echan0524 if you only want to highlight instead of "selecting" it, then i would again recommend using a selector, in that case you can just modify the state of the tab, and then the drawable will change. there is no need to add ifs all the way just to avoid actually selecting it. |
@yombunker |
@echan0524 i don't understand what you mean with select but don't highlight? what's the difference between select and the current behavior of select? maybe i'm the one with the problem, but, i don't understand the problem you are trying to solve. can you explain me what's the goal of this. |
@echan0524 still waiting on your description, because for me it looks like you only want to "change" the highlighted state of the tab, which like i said you could get that with drawable selector |
added new methods to select/highlight tab without triggering listener.
highlightTabWithId()
highlightTabAtPosition()