fix: column min extent #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfsxreloader
requested review from
bernardobelchior,
canastro,
freitzzz,
RafaelSeSouza,
renancaraujo and
victorbotamedi
freitzzz
approved these changes
Jun 13, 2022
canastro
reviewed
Jun 13, 2022
| @@ -24,5 +24,7 @@ double headerWidthForRange(Range range) { | |||
| const kDefaultCellWidth = 120.0; | |||
| const kDefaultCellHeight = 33.0; | |||
|
|
|||
| const kMinCellWidth = 30.0; | |||
There was a problem hiding this comment.
This should, probably, be configurable by the user. This can be merged as is, but an US should be created to allow the user to override these constants (not just this particular one)
canastro
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Users should be able to resize columns to a smaller width.
Since there are more things that need to be configurable for resize, configuring this extent is out of scope of this PR.