Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: column min extent #15

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: column min extent #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/swayze/lib/src/config.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,7 @@ double headerWidthForRange(Range range) {
const kDefaultCellWidth = 120.0;
const kDefaultCellHeight = 33.0;

const kMinCellWidth = 30.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should, probably, be configurable by the user. This can be merged as is, but an US should be created to allow the user to override these constants (not just this particular one)


const kDefaultScrollAnimationDuration = Duration(milliseconds: 50);
const kDefaultScrollAnimationCurve = Curves.easeOut;
2 changes: 1 addition & 1 deletion ...ges/swayze/lib/src/widgets/headers/gestures/resize_header/header_edge_mouse_listener.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ class _HeaderEdgeMouseListenerState extends State<HeaderEdgeMouseListener> {
}

double minExtent(Axis axis) =>
axis == Axis.horizontal ? kDefaultCellWidth : kDefaultCellHeight;
axis == Axis.horizontal ? kMinCellWidth : kDefaultCellHeight;

/// Inserts an [OverlayEntry] to the current [OverlayState] with resize line
/// on it at the header edge that is being hovered.
Expand Down