rename to just rpm #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
force-pushed
the
bernhard-just-rpm
branch
from
0614ff9
to
22a6ef5
Compare
Closed
drahnr
force-pushed
the
bernhard-just-rpm
branch
from
3efc054
to
0a58559
Compare
dralley
approved these changes
Nov 21, 2022
|
Renamed repository to |
That's fine with me, I'm slightly partial to picking up where the other crate left off in terms of versioning, but I don't feel strongly about it at all |
|
We could do either, no strong opinion either. |
|
I don't think we need to overthink the "when" too much, the signing fix alone is justification for a release. We need to update the changelog though - probably we should have been doing that in the PRs, but it slipped my mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4
I propose to craft a release as
0.0.1under the new namerpmwith the current state and iterate quickly and bump to0.1.0once a decent level of documentation exists.Once merged, I'd also rename the name of this repo accordingly to
rpm