Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing is-active testing for sibling, equal and ancestor routes #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing is-active testing for sibling, equal and ancestor routes #92

wants to merge 1 commit into from

Conversation

rpocklin
Copy link
Owner

@rpocklin rpocklin commented Jul 3, 2017 •
edited
Loading

This should resolve issues around #91 and #71 collectively.

@rpocklin
Copy link
Owner Author

rpocklin commented Jul 4, 2017

@fa137 @ollycross can you review this for me? I will investigate why these builds are failing.

@rpocklin rpocklin force-pushed the fix-is-active branch 2 times, most recently from 692f35c to e4f1700 Compare July 4, 2017 23:44
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.2%) to 94.444% when pulling 2f486cc on fix-is-active into db413f4 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpocklin @coveralls