Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call out NS2.0 dependency in README #411

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Call out NS2.0 dependency in README #411

merged 1 commit into from
Apr 3, 2023

Conversation

IanKemp
Copy link
Contributor

@IanKemp IanKemp commented Mar 30, 2023

Partially addresses pain of #222 and #239.

@ErikEJ ErikEJ self-requested a review April 3, 2023 06:35
@ErikEJ ErikEJ requested review from jeffrosenberg and jmezach April 3, 2023 06:36
jmezach
jmezach approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmezach jmezach merged commit 1874b71 into rr-wfm:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikEJ ErikEJ ErikEJ approved these changes

@jmezach jmezach jmezach approved these changes

@jeffrosenberg jeffrosenberg Awaiting requested review from jeffrosenberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanKemp @jmezach @ErikEJ