Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report DacModelExceptions better, and continue processing all files #598

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

ErikEJ
Copy link
Collaborator

@ErikEJ ErikEJ commented Aug 1, 2024

fixes #595

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Aug 1, 2024

image

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Aug 1, 2024

Build started at 07:30...
1>------ Build started: Project: TestProjectWithErrors, Configuration: Debug Any CPU ------
1>Using target framework net8.0 to run DacpacTool
1>Using package name TestProjectWithErrors and version 1.0.0
1>Using SQL Server version Sql150
1>Adding C:\Code\Github\MSBuild.Sdk.SqlProj\test\TestProjectWithErrors\Tables\MyTable.sql to the model
1>MyTable.sql(1,1): error SQL71006: Only one statement is allowed per batch. A batch separator, such as 'GO', might be required between statements.
1>Adding C:\Code\Github\MSBuild.Sdk.SqlProj\test\TestProjectWithErrors\Tables\MyTable2.sql to the model
1>MyTable2.sql(1,1): error SQL71006: Only one statement is allowed per batch. A batch separator, such as 'GO', might be required between statements.
1>C:\Code\Github\MSBuild.Sdk.SqlProj\src\MSBuild.Sdk.SqlProj\Sdk\Sdk.targets(243,5): error MSB3073: The command "dotnet "C:\Code\Github\MSBuild.Sdk.SqlProj\src\MSBuild.Sdk.SqlProj\Sdk\../tools/net8.0/DacpacTool.dll" build -o "obj\Debug\netstandard2.0\TestProjectWithErrors.dacpac" -n "TestProjectWithErrors" -v "1.0.0" -sv Sql150 -i "obj\Debug\netstandard2.0\TestProjectWithErrors.InputFiles.txt"    -dp IncludeCompositeObjects=true           " exited with code 1.
1>Done building project "TestProjectWithErrors.csproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
========== Build completed at 07:30 and took 01,579 seconds ==========

@ErikEJ ErikEJ requested review from jeffrosenberg and jmezach August 1, 2024 05:43
test/DacpacTool.Tests/PackageBuilderTests.cs Show resolved Hide resolved
src/DacpacTool/Extensions.cs Show resolved Hide resolved
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Aug 2, 2024

Phew - that was an "interesting" breaking SQL container change 😄

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Aug 2, 2024

@jmezach All lights are green now 😄

@jmezach
Copy link
Member

jmezach commented Aug 2, 2024

Looks like I can't approve this from my phone. Will do so when I get back home in about half an hour ;)

@jmezach
Copy link
Member

jmezach commented Aug 2, 2024

Phew - that was an "interesting" breaking SQL container change 😄

Looks like we weren't the only ones hit by this breaking change: microsoft/mssql-docker#892

Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged, nice fix I think :)

@ErikEJ ErikEJ merged commit 69689ef into rr-wfm:master Aug 2, 2024
13 checks passed
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Aug 2, 2024

@jmezach Agree, this is a good quality improvement

@jmezach
Copy link
Member

jmezach commented Aug 2, 2024

Should we release this as 2.8.1?

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Aug 2, 2024

I have a plan for a PR to run some .NET analyzers against the DacpacTool codebase (our code, not the modules) - maybe after that?

@jmezach
Copy link
Member

jmezach commented Aug 2, 2024

Sure thing :)

@ErikEJ ErikEJ mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filename missing in the error message
3 participants