-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report DacModelExceptions better, and continue processing all files #598
Conversation
|
Phew - that was an "interesting" breaking SQL container change 😄 |
@jmezach All lights are green now 😄 |
Looks like I can't approve this from my phone. Will do so when I get back home in about half an hour ;) |
Looks like we weren't the only ones hit by this breaking change: microsoft/mssql-docker#892 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged, nice fix I think :)
@jmezach Agree, this is a good quality improvement |
Should we release this as 2.8.1? |
I have a plan for a PR to run some .NET analyzers against the DacpacTool codebase (our code, not the modules) - maybe after that? |
Sure thing :) |
fixes #595