Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for StaticCodeAnalysis.SuppressMessages.xml #643

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

ErikEJ
Copy link
Collaborator

@ErikEJ ErikEJ commented Oct 18, 2024

In order to suppress rules for individual files

fixes #578

@ErikEJ ErikEJ requested a review from jeffrosenberg October 18, 2024 08:14
Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off to a great start I think. Really appreciate you taking the time to move this project forward @ErikEJ.

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Oct 18, 2024

@jmezach Thanks, I think we still have potential to be a great .dacpac build SDK for a while

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Oct 18, 2024

@jmezach Attempted to set current dir

Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Oct 23, 2024

@jeffrosenberg Hope you had a nice holiday. Would be grateful if you could have a look at this 🙏

@ErikEJ ErikEJ merged commit 3fe3a62 into rr-wfm:master Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline IGNORE comments for SqlServer.Rules are being ignored
3 participants