Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated GIF Support #375

Merged
merged 4 commits into from
Apr 28, 2013
Merged

Animated GIF Support #375

merged 4 commits into from
Apr 28, 2013

Conversation

lavoy
Copy link
Contributor

@lavoy lavoy commented Apr 28, 2013

No description provided.

@lavoy lavoy mentioned this pull request Apr 28, 2013
@MattFoley
Copy link

Very awesome!

@rs
Copy link
Member

rs commented Apr 28, 2013

Awesome! Could you just reformat the code to match to project coding style please? (brackets on their own lines)

@lavoy
Copy link
Contributor Author

lavoy commented Apr 28, 2013

Sure thing. Sorry about that.

@rs
Copy link
Member

rs commented Apr 28, 2013

no pb, thanks for the great work

@lavoy
Copy link
Contributor Author

lavoy commented Apr 28, 2013

It would be nice to have a way to tell the user that the image is a GIF or not so they know how to process it later. Maybe an extra param in SDWebImageCompletedWithFinishedBlock but that would break compatibility. Thoughts?

@rs
Copy link
Member

rs commented Apr 28, 2013

What about:

BOOL isAnimatedGIF = image.images != nil;

@lavoy
Copy link
Contributor Author

lavoy commented Apr 28, 2013

Ah, that works well. No change needed then.

rs pushed a commit that referenced this pull request Apr 28, 2013
@rs rs merged commit 5db0d00 into SDWebImage:master Apr 28, 2013
@MattFoley
Copy link

#377 Adds a getter for that to both UIImage and UIImageView, convenience/readability method for any future users.

@fanyj
Copy link

fanyj commented May 2, 2013

THIS IS AWESOME! Great featrue!
I been trying to integerate LBGIFImage into my project for weeks.
Since it use method

(UIImage *)animatedImageNamed:(NSString *)name duration:(NSTimeInterval)duration 

, there may be some efficiency problem when playing a large gif (I just experience this problem).
At last I move to [https://github.com/ondalabs/OLImageView] and it works fine for me.
I think we shall keep an eye on this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants