Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Ethereum compatibility while deploying contracts #2802

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Enhance Ethereum compatibility while deploying contracts #2802

merged 7 commits into from
Dec 17, 2024

Conversation

asoto-iov
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@rmoreliovlabs rmoreliovlabs force-pushed the enhance_eth_compatibility_contract_deployment branch from ce4ae35 to 5458b42 Compare November 26, 2024 13:47
@rmoreliovlabs rmoreliovlabs marked this pull request as ready for review November 27, 2024 01:30
fmacleal
fmacleal previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I see that the coverage seems very good with the contracts.
I just have a few comments with simple suggestions, but nothing that prevent the approval.

Vovchyk
Vovchyk previously approved these changes Nov 29, 2024
View reviewed changes
fmacleal
fmacleal previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Thanks for have addressed the comments. :)

@Vovchyk Vovchyk dismissed stale reviews from fmacleal and themself via 428263c December 17, 2024 11:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Vovchyk Vovchyk removed the request for review from marcos-iov December 17, 2024 11:40
nagarev
nagarev approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@nagarev nagarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

fmacleal
fmacleal approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@fmacleal fmacleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vovchyk Vovchyk merged commit 50137dc into master Dec 17, 2024
13 checks passed
@Vovchyk Vovchyk deleted the enhance_eth_compatibility_contract_deployment branch December 17, 2024 14:12
@aeidelman aeidelman added this to the Lovell 7.0.0 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoreliovlabs rmoreliovlabs rmoreliovlabs left review comments

@Vovchyk Vovchyk Vovchyk approved these changes

@nagarev nagarev nagarev approved these changes

@fmacleal fmacleal fmacleal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Lovell 7.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@asoto-iov @Vovchyk @nagarev @rmoreliovlabs @fmacleal @aeidelman