Skip to content

Commit b9ea3eb

Browse files
committed
Revert "Feature/rate limiter publisher (#672)"
This reverts commit 88ee909
1 parent 33259c2 commit b9ea3eb

File tree

11 files changed

+23
-412
lines changed

11 files changed

+23
-412
lines changed

rsocket-core/src/main/java/io/rsocket/RSocketRequester.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import io.rsocket.exceptions.Exceptions;
2828
import io.rsocket.frame.*;
2929
import io.rsocket.frame.decoder.PayloadDecoder;
30-
import io.rsocket.internal.RateLimitableRequestPublisher;
30+
import io.rsocket.internal.LimitableRequestPublisher;
3131
import io.rsocket.internal.SynchronizedIntObjectHashMap;
3232
import io.rsocket.internal.UnboundedProcessor;
3333
import io.rsocket.internal.UnicastMonoProcessor;
@@ -47,7 +47,6 @@
4747
import org.reactivestreams.Subscriber;
4848
import org.reactivestreams.Subscription;
4949
import reactor.core.publisher.*;
50-
import reactor.util.concurrent.Queues;
5150

5251
/**
5352
* Requester Side of a RSocket socket. Sends {@link ByteBuf}s to a {@link RSocketResponder} of peer
@@ -61,7 +60,7 @@ class RSocketRequester implements RSocket {
6160
private final PayloadDecoder payloadDecoder;
6261
private final Consumer<Throwable> errorConsumer;
6362
private final StreamIdSupplier streamIdSupplier;
64-
private final IntObjectMap<RateLimitableRequestPublisher> senders;
63+
private final IntObjectMap<LimitableRequestPublisher> senders;
6564
private final IntObjectMap<Processor<Payload, Payload>> receivers;
6665
private final UnboundedProcessor<ByteBuf> sendProcessor;
6766
private final RequesterLeaseHandler leaseHandler;
@@ -132,7 +131,7 @@ private void handleSendProcessorError(Throwable t) {
132131
}
133132
});
134133

135-
senders.values().forEach(RateLimitableRequestPublisher::cancel);
134+
senders.values().forEach(LimitableRequestPublisher::cancel);
136135
}
137136

138137
private void handleSendProcessorCancel(SignalType t) {
@@ -151,7 +150,7 @@ private void handleSendProcessorCancel(SignalType t) {
151150
}
152151
});
153152

154-
senders.values().forEach(RateLimitableRequestPublisher::cancel);
153+
senders.values().forEach(LimitableRequestPublisher::cancel);
155154
}
156155

157156
@Override
@@ -344,8 +343,8 @@ public void accept(long n) {
344343
request
345344
.transform(
346345
f -> {
347-
RateLimitableRequestPublisher<Payload> wrapped =
348-
RateLimitableRequestPublisher.wrap(f, Queues.SMALL_BUFFER_SIZE);
346+
LimitableRequestPublisher<Payload> wrapped =
347+
LimitableRequestPublisher.wrap(f);
349348
// Need to set this to one for first the frame
350349
wrapped.request(1);
351350
senders.put(streamId, wrapped);
@@ -422,7 +421,7 @@ protected void hookOnError(Throwable t) {
422421
.doFinally(
423422
s -> {
424423
receivers.remove(streamId);
425-
RateLimitableRequestPublisher sender = senders.remove(streamId);
424+
LimitableRequestPublisher sender = senders.remove(streamId);
426425
if (sender != null) {
427426
sender.cancel();
428427
}
@@ -490,7 +489,7 @@ private void setTerminationError(Throwable error) {
490489
}
491490

492491
private synchronized void cleanUpLimitableRequestPublisher(
493-
RateLimitableRequestPublisher<?> limitableRequestPublisher) {
492+
LimitableRequestPublisher<?> limitableRequestPublisher) {
494493
try {
495494
limitableRequestPublisher.cancel();
496495
} catch (Throwable t) {
@@ -562,7 +561,7 @@ private void handleFrame(int streamId, FrameType type, ByteBuf frame) {
562561
break;
563562
case CANCEL:
564563
{
565-
RateLimitableRequestPublisher sender = senders.remove(streamId);
564+
LimitableRequestPublisher sender = senders.remove(streamId);
566565
if (sender != null) {
567566
sender.cancel();
568567
}
@@ -573,7 +572,7 @@ private void handleFrame(int streamId, FrameType type, ByteBuf frame) {
573572
break;
574573
case REQUEST_N:
575574
{
576-
RateLimitableRequestPublisher sender = senders.get(streamId);
575+
LimitableRequestPublisher sender = senders.get(streamId);
577576
if (sender != null) {
578577
int n = RequestNFrameFlyweight.requestN(frame);
579578
sender.request(n >= Integer.MAX_VALUE ? Long.MAX_VALUE : n);

rsocket-core/src/main/java/io/rsocket/RSocketResponder.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import io.rsocket.exceptions.ApplicationErrorException;
2424
import io.rsocket.frame.*;
2525
import io.rsocket.frame.decoder.PayloadDecoder;
26-
import io.rsocket.internal.RateLimitableRequestPublisher;
26+
import io.rsocket.internal.LimitableRequestPublisher;
2727
import io.rsocket.internal.SynchronizedIntObjectHashMap;
2828
import io.rsocket.internal.UnboundedProcessor;
2929
import io.rsocket.lease.ResponderLeaseHandler;
@@ -35,7 +35,6 @@
3535
import reactor.core.Disposable;
3636
import reactor.core.Exceptions;
3737
import reactor.core.publisher.*;
38-
import reactor.util.concurrent.Queues;
3938

4039
/** Responder side of RSocket. Receives {@link ByteBuf}s from a peer's {@link RSocketRequester} */
4140
class RSocketResponder implements ResponderRSocket {
@@ -47,7 +46,7 @@ class RSocketResponder implements ResponderRSocket {
4746
private final Consumer<Throwable> errorConsumer;
4847
private final ResponderLeaseHandler leaseHandler;
4948

50-
private final IntObjectMap<RateLimitableRequestPublisher> sendingLimitableSubscriptions;
49+
private final IntObjectMap<LimitableRequestPublisher> sendingLimitableSubscriptions;
5150
private final IntObjectMap<Subscription> sendingSubscriptions;
5251
private final IntObjectMap<Processor<Payload, Payload>> channelProcessors;
5352

@@ -436,8 +435,8 @@ private void handleStream(int streamId, Flux<Payload> response, int initialReque
436435
response
437436
.transform(
438437
frameFlux -> {
439-
RateLimitableRequestPublisher<Payload> payloads =
440-
RateLimitableRequestPublisher.wrap(frameFlux, Queues.SMALL_BUFFER_SIZE);
438+
LimitableRequestPublisher<Payload> payloads =
439+
LimitableRequestPublisher.wrap(frameFlux);
441440
sendingLimitableSubscriptions.put(streamId, payloads);
442441
payloads.request(
443442
initialRequestN >= Integer.MAX_VALUE ? Long.MAX_VALUE : initialRequestN);

rsocket-core/src/main/java/io/rsocket/internal/RateLimitableRequestPublisher.java

Lines changed: 0 additions & 242 deletions
This file was deleted.

0 commit comments

Comments
 (0)