Skip to content
This repository has been archived by the owner on Nov 30, 2024. It is now read-only.

Drop dead (private) methods from BaseMatcher #1457

Merged
merged 2 commits into from
May 9, 2024
Merged

Drop dead (private) methods from BaseMatcher #1457

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e009fe
drop assert_ivars/present_ivars from BaseMatcher
nevinera May 8, 2024
8a1429d
Remove surplus access modifier.
JonRowe May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions lib/rspec/matchers/built_in/base_matcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,22 +126,6 @@ def self.underscore(camel_cased_word)

private
JonRowe marked this conversation as resolved.
Show resolved Hide resolved

def assert_ivars(*expected_ivars)
return unless (expected_ivars - present_ivars).any?
ivar_list = EnglishPhrasing.list(expected_ivars)
raise "#{self.class.name} needs to supply#{ivar_list}"
end

if RUBY_VERSION.to_f < 1.9
# :nocov:
def present_ivars
instance_variables.map(&:to_sym)
end
# :nocov:
else
alias present_ivars instance_variables
end

# @private
module HashFormatting
# `{ :a => 5, :b => 2 }.inspect` produces:
Expand Down
Loading