-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specifying parent container #33
Conversation
Throwing a big +1 to this one, would be super handy |
When I first saw NProgress I said "Neat!", second thing I said was "wonder if I can change the containing element..." +1 on this PR |
+1 |
+1. |
👍 |
👍 |
+1 |
+100 for this feature. |
👍 pls add this |
@rstacruz any way we could get this in? Pretty please... |
+1 |
Looking at this now. I think I'd like to see this refined a little further to be merge-ready:
|
Updated PR here: #86 |
This has now been implemented. Thanks @jonjaques! Documented here: https://github.com/rstacruz/nprogress/blob/master/Readme.md#parent |
I've updated this PR to include a few tests and squash it down to 1 commit. Closes #14.
There was one hiccup I did not anticipate originally: changing the bar to be absolutely positioned within its container (by default the
body
), prevents it from being visible when the document is scrolled.My solution was to set the position to
fixed
only when the parent is thebody
.