Add support for specifying parent container #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Any chance it will get merged this time? |
|
@gabegorelick hi! This is pretty much the same as the issue I just opened right? #84 |
|
@frankie-loves-jesus Yes, it's a very common feature request. |
|
@jasonLaster could you merge https://github.com/jasonLaster/nprogress/tree/parent2 into your master so I can Also, I updated @jonjaques's testcase with his latest code: |
|
Thank you @rstacruz! |
|
Thank you guys too for reporting issues and sending out your PRs! If you'd like me to look at any specific issue that I may have overlooked, just ping me on Twitter/email/mention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates #33, which has gone stale.