-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server-side processing support for SearchBuilder #1113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This is incredible. Thank you so much!
Please add a news item and I think it'll be ready to merge.
Happy to help. And thank you for blogging about this! You were right, this was a fun project. I added the NEWS item and also:
|
Thanks a lot for the work @mikmart , @yihui Just a question that i cannot find an answer to, i used the code above to test, works like a charm, but for the factor column (c), when i try to add a condition, it is giving me a textbox instead of dropdown of choices, is this how it is supposed to be? or should i add another option somewhere to let me choose from fixed values (since it is a factor), Thanks in advance, |
Thanks for trying it out @AhmedKhaled945! What you're seeing is actually a documented feature of the SearchBuilder extension in server-side processing mode (emphasis added):
I'm not aware of any straightforward way to change this behaviour. |
Ok got it, thanks a lot @mikmart |
Fixes #963.
This PR adds support for SearchBuilder in server-side processing. I did not add support for the
moment
orluxon
column types as I'm not sure how they map to R types. Thearray
column type is not supported either.Notably datetime columns are treated as character data. This seems to be a limitation with the SearchBuilder extension.
I was not sure how to map the
null
or empty conditions into R. The approach I chose was to map them to missing values, and, for character columns, also to empty strings.I added some unit tests to confirm that the main components in the processing work as intended, but did not attempt to get thorough coverage on all cases. In addition to the unit tests, I used this app for some further manual testing: