Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use log entry for status bar instead of a final graph #67

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Use log entry for status bar instead of a final graph #67

merged 3 commits into from
Aug 24, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Jun 2, 2020 •
edited
Loading

Fixes #60

Do not read the current value from a graph that has processed all log entries

Instead read from the current log entry

PR task list:

  • Passes devtools::check()
  • Add NEWS entry explaining change (reference username and PR#)
  • [NA] Add tests (if appropriate)
  • [NA] Update documentation with devtools::document()

@schloerke
Do not read the current value from a graph that has processed all log…
49d7655 
… entries

Instead read from the current log entry
@schloerke schloerke added this to the v1.1.0 milestone Jun 2, 2020
@schloerke schloerke self-assigned this Jun 2, 2020
@schloerke schloerke requested a review from cpsievert June 2, 2020 20:51
@schloerke schloerke merged commit b016fa0 into master Aug 24, 2020
@schloerke schloerke deleted the status_bar_sync branch August 24, 2020 15:47
schloerke added a commit that referenced this pull request Aug 24, 2020
@schloerke
Merge branch 'master' into reactlog_module
e9fa1ff 
* master:
  Use log entry for status bar instead of a final graph (#67)
  UTF-8 support when parsing JSON (#64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Status bar is not synced with raw data
2 participants
@schloerke @cpsievert