Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that we're only showing a subset of incorrect values #101

Open
gadenbuie opened this issue Nov 22, 2021 · 0 comments
Open

Indicate that we're only showing a subset of incorrect values #101

gadenbuie opened this issue Nov 22, 2021 · 0 comments
Assignees

Comments

@gadenbuie
Copy link
Member

gadenbuie commented Nov 22, 2021

In the following example, there are 5 unequal values in the column being checked.

pkgload::load_all()
#> ℹ Loading tblcheck

.result <- tibble::tibble(x = c(1:5, runif(5)))
.solution <- tibble::tibble(x = c(1:5, runif(5)))

But the values problem message only shows us 3 values and doesn't give any indication that there are more issues than these three.

tbl_grade_column("x")
#> <gradethis_graded: [Incorrect]
#>   I didn't expect your `x` column to include the values `0.2423`,
#>   `0.1420`, and `0.0605`.
#> >

We should either:

  1. Show the number of total errors, e.g.

    Your x column contains 5 unexpected values including 0.2423, 0.1420, and 0.0605.

  2. Give a hint that there are more errors, e.g.

    I didn't expect your x column to include the values 0.2423, 0.1420, and 0.0605 and 2 more.

  3. Both?

    Your x column contains 5 unexpected values including 0.2423, 0.1420, and 0.0605 and 2 more.

@rossellhayes rossellhayes self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants