Use the graceful leave behaviour in rtc-signal #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume these test failures are service related and not actual fails (given the changes) Is there hold up on the review and approval of this. We would like to update and run some new tests |
|
Sorry about the delay @warrenjmcdonald - I just wanted to have a bit more of a look at the failing tests before merging in the PR. I've done so now and published the new package as |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use
rtc-signal@1.3.0and the graceful leave behaviour of sending a/leavemessage prior to disconnect. (see rtc-io/rtc-quickconnect#81)