From ed724cb59ae885454fa92164ccc1f772c216a6ae Mon Sep 17 00:00:00 2001 From: Vlad Pisanov Date: Sat, 17 Aug 2024 14:30:09 -0400 Subject: [PATCH] Fix `RuboCop::AST::DefNode#void_context?` to handle class methods called `initialize` --- changelog/fix_def_node_void_context.md | 1 + lib/rubocop/ast/node/def_node.rb | 2 +- spec/rubocop/ast/def_node_spec.rb | 6 ++++++ 3 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 changelog/fix_def_node_void_context.md diff --git a/changelog/fix_def_node_void_context.md b/changelog/fix_def_node_void_context.md new file mode 100644 index 000000000..27634d387 --- /dev/null +++ b/changelog/fix_def_node_void_context.md @@ -0,0 +1 @@ +* [#310](https://github.com/rubocop/rubocop-ast/pull/310): Fix `RuboCop::AST::DefNode#void_context?` to handle class methods called `initialize`. ([@vlad-pisanov][]) diff --git a/lib/rubocop/ast/node/def_node.rb b/lib/rubocop/ast/node/def_node.rb index 96a61d631..22290459c 100644 --- a/lib/rubocop/ast/node/def_node.rb +++ b/lib/rubocop/ast/node/def_node.rb @@ -13,7 +13,7 @@ class DefNode < Node # # @return [Boolean] whether the `def` node body is a void context def void_context? - method?(:initialize) || assignment_method? + (def_type? && method?(:initialize)) || assignment_method? end # Checks whether this method definition node forwards its arguments diff --git a/spec/rubocop/ast/def_node_spec.rb b/spec/rubocop/ast/def_node_spec.rb index e24ed0ac5..22f1631d7 100644 --- a/spec/rubocop/ast/def_node_spec.rb +++ b/spec/rubocop/ast/def_node_spec.rb @@ -324,6 +324,12 @@ it { is_expected.to be_void_context } end + context 'with a class method called "initialize"' do + let(:source) { 'def self.initialize(bar); end' } + + it { is_expected.not_to be_void_context } + end + context 'with a regular assignment method' do let(:source) { 'def foo=(bar); end' }