Add Capybara/AmbiguousClick cop and make soft-deprecated Capybara/ClickLinkOrButtonStyle cop. If you want to use EnforcedStyle: strict, use Capybara/AmbiguousClick cop instead
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2024
ydah
commented
Jan 15, 2024
| Capybara/ClickLinkOrButtonStyle: | ||
| Description: Checks for methods of button or link clicks. | ||
| Enabled: pending | ||
| Enabled: false |
There was a problem hiding this comment.
memo) This is a change from pending, but is this acceptable for a minor update? (not a breaking change?)
ydah
commented
Jan 15, 2024
| @@ -9,11 +9,17 @@ Capybara: | |||
| - "**/*_steps.rb" | |||
| - "**/features/step_definitions/**/*" | |||
|
|
|||
| Capybara/AmbiguousClick: | |||
| Description: Specify the exact target to click on. | |||
| Enabled: false | |||
There was a problem hiding this comment.
memo) It is not to be enabled by default. It is only a transition destination when Capybara/ClickLinkOrButtonStyle is EnforcedStyle: strict.
jgarber623
pushed a commit
to CargoSense/rubocop-cargosense
that referenced
this pull request
May 6, 2024
This rule's default enforce style, `link_or_button` [1], introduced a number of problems [2]. Specifically, I noticed issues switching to `click_on` from `click_button` [3]. The hack solution is to ignore or disable the rule in some places but not in others. Not great. As a result, the rule is slated for removal [4] and replacement [5] by a new rule. In the interim, configuring this rule to enforce a strict use of `click_button` and `click_link` is preferential (and, honestly, more communicative). In this author's opinion, user interface specs should be explicit about the markup under test. [1] https://docs.rubocop.org/rubocop-capybara/cops_capybara.html#capybaraclicklinkorbuttonstyle [2] rubocop/rubocop-capybara#61 [3] rubocop/rubocop-capybara#61 (comment) [4] rubocop/rubocop-capybara#81 [5] rubocop/rubocop-capybara#99
jgarber623
pushed a commit
to CargoSense/rubocop-cargosense
that referenced
this pull request
May 6, 2024
## Description This rule's default enforce style, `link_or_button` [1], introduced a number of problems [2]. Specifically, I noticed issues switching to `click_on` from `click_button` [3]. The hack solution is to ignore or disable the rule in some places but not in others. Not great. As a result, the rule is slated for removal [4] and replacement [5] by a new rule. In the interim, configuring this rule to enforce a strict use of `click_button` and `click_link` is preferential (and, honestly, more communicative). In this author's opinion, user interface specs should be explicit about the markup under test. [1] https://docs.rubocop.org/rubocop-capybara/cops_capybara.html#capybaraclicklinkorbuttonstyle [2] rubocop/rubocop-capybara#61 [3] rubocop/rubocop-capybara#61 (comment) [4] rubocop/rubocop-capybara#81 [5] rubocop/rubocop-capybara#99 ## Commits - Configure `Capybara/ClickLinkOrButtonStyle` - Bump version to v1.1.0
…ClickLinkOrButtonStyle` cop. If you want to use `EnforcedStyle: strict`, use `Capybara/AmbiguousClick` cop instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: #81
Before submitting the PR make sure the following are checked:
main(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.Enabled: pendinginconfig/default.yml.VersionAdded: "<<next>>"indefault/config.yml.If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"inconfig/default.yml.