Merge pull request #127 from koic/mark_assert_with_expected_argument_…

…as_unsafe

[Fix #126] Mark `Minitest/AssertWithExpectedArgument` as unsafe

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Changes
+
+* [#126](https://github.com/rubocop/rubocop-minitest/issues/126): Mark `Minitest/AssertWithExpectedArgument` as unsafe. ([@koic][])
+
 ## 0.11.0 (2021-03-22)
 
 ### New features

config/default.yml

@@ -97,6 +97,7 @@ Minitest/AssertTruthy:
 Minitest/AssertWithExpectedArgument:
   Description: 'This cop tries to detect when a user accidentally used `assert` when they meant to use `assert_equal`.'
   Enabled: pending
+  Safe: false
   VersionAdded: '0.11'
 
 Minitest/GlobalExpectations:

docs/modules/ROOT/pages/cops_minitest.adoc

@@ -447,7 +447,7 @@ assert(actual, 'message')
 | Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
 
 | Pending
-| Yes
+| No
 | No
 | 0.11
 | -
@@ -456,6 +456,9 @@ assert(actual, 'message')
 This cop tries to detect when a user accidentally used
 `assert` when they meant to use `assert_equal`.
 
+It is marked as unsafe because it is not possible to determine
+whether the second argument of `assert` is a message or not.
+
 === Examples
 
 [source,ruby]

lib/rubocop/cop/minitest/assert_with_expected_argument.rb

@@ -6,6 +6,9 @@ module Minitest
       # This cop tries to detect when a user accidentally used
       # `assert` when they meant to use `assert_equal`.
       #
+      # It is marked as unsafe because it is not possible to determine
+      # whether the second argument of `assert` is a message or not.
+      #
       # @example
       #   # bad
       #   assert(3, my_list.length)