Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Performance/ReverseFirst aware of safe navigation operator #411

Closed
ydakuka opened this issue Dec 1, 2023 · 0 comments
Closed

Make Performance/ReverseFirst aware of safe navigation operator #411

ydakuka opened this issue Dec 1, 2023 · 0 comments

Comments

@ydakuka
Copy link
Contributor

ydakuka commented Dec 1, 2023

Describe the solution you'd like

# bad
def my_method
  array&.reverse&.first
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.58.0 (using Parser 3.2.2.4, rubocop-ast 1.30.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
koic added a commit to koic/rubocop-performance that referenced this issue Dec 7, 2023
Fixes rubocop#403, rubocop#404, rubocop#405, rubocop#406, rubocop#408, rubocop#411, rubocop#412, rubocop#413, rubocop#415, rubocop#416, and rubocop#417.

This PR makes `Performance/Count`, `Performance/FixedSize`, `Performance/FlatMap`,
`Performance/InefficientHashSearch`, `Performance/RangeInclude`, `Performance/RedundantSortBlock`,
`Performance/ReverseFirst`, `Performance/SelectMap`, `Performance/Size` `Performance/SortReverse`,
and `Performance/TimesMap` cops aware of safe navigation operator.
@koic koic closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants