Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TopLevelGroup instead of TopLevelDescribe #948

Closed
pirj opened this issue Jun 28, 2020 · 0 comments · Fixed by #977 or #978
Closed

Use TopLevelGroup instead of TopLevelDescribe #948

pirj opened this issue Jun 28, 2020 · 0 comments · Fixed by #977 or #978
Milestone
2.0

Comments

@pirj
Copy link
Member

pirj commented Jun 28, 2020

The newly introduced TopLevelGroup is better (see the pull request introducing it) since it not only detects describe, but other flavours of top-level example groups.
Consider using TopLevelGroup in our own cops.
Deprecate TopLevelDescribe and eventually remove in 2.0 (not earlier, since custom cops may depend on it).
@pirj pirj added this to the 2.0 milestone Jul 15, 2020
@pirj pirj mentioned this issue Jul 22, 2020
Merged
6 tasks
@pirj pirj linked a pull request Jul 23, 2020 that will close this issue
Retire TopLevelDescribe #978
Merged
7 tasks
@pirj pirj closed this as completed in #977 Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
1 participant
@pirj