chore: add mixed option for quote_style #315
Conversation
Sometimes when we are working in a legacy code formatting a string changing its quote style is not something we really want because it makes a PR review hard as a lot of modifications may be made. With this option a developer can choose if that modification is needed or not issue: ruby-formatter#258
|
Rufo's basic stance is that we don't want to increase the number of settings. However, it seems that there are many cases where this setting would be a problem if it were not there. I would like to make an exception and accept a modification to add this setting. @lockland thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 97.15% 97.16%
=======================================
Files 19 19
Lines 2992 2993 +1
=======================================
+ Hits 2907 2908 +1
Misses 85 85 ☔ View full report in Codecov by Sentry. |
|
Thanks @kzkn for your help!! I would like to say that this stance makes a lot of sense to me and congrats you all by this amazing job you are doing in this project that allows me being more productive and to focus on what matter which is the code. |
Sometimes when we are working in a legacy code formatting a string changing its quote style is not something we really want to because it makes a PR review harder as a lot of modifications may be made.
With this option a developer can choose if that modification is needed or not
issue: #258