diff --git a/lib/net/ldap.rb b/lib/net/ldap.rb index 9c13a97d..08ad0980 100644 --- a/lib/net/ldap.rb +++ b/lib/net/ldap.rb @@ -1320,7 +1320,7 @@ def new_connection # Force connect to see if there's a connection error connection.socket connection - rescue Errno::ECONNREFUSED, Errno::ETIMEDOUT, Net::LDAP::ConnectionRefusedError => e + rescue Errno::ECONNREFUSED, Errno::ETIMEDOUT => e @result = { :resultCode => 52, :errorMessage => ResultStrings[ResultCodeUnavailable], diff --git a/lib/net/ldap/error.rb b/lib/net/ldap/error.rb index 50442d06..c672dc17 100644 --- a/lib/net/ldap/error.rb +++ b/lib/net/ldap/error.rb @@ -1,38 +1,13 @@ class Net::LDAP - class LdapError < StandardError - def message - "Deprecation warning: Net::LDAP::LdapError is no longer used. Use Net::LDAP::Error or rescue one of it's subclasses. \n" + super - end - end - class Error < StandardError; end class AlreadyOpenedError < Error; end class SocketError < Error; end - class ConnectionRefusedError < Error; - def initialize(*args) - warn_deprecation_message - super - end - - def message - warn_deprecation_message - super - end - - private - - def warn_deprecation_message - warn "Deprecation warning: Net::LDAP::ConnectionRefused will be deprecated. Use Errno::ECONNREFUSED instead." - end - end class ConnectionError < Error def self.new(errors) error = errors.first.first if errors.size == 1 - if error.kind_of? Errno::ECONNREFUSED - return Net::LDAP::ConnectionRefusedError.new(error.message) - end + return error if error.is_a? Errno::ECONNREFUSED return Net::LDAP::Error.new(error.message) end diff --git a/test/integration/test_bind.rb b/test/integration/test_bind.rb index 7df263c1..83ed3c07 100644 --- a/test/integration/test_bind.rb +++ b/test/integration/test_bind.rb @@ -1,7 +1,6 @@ require_relative '../test_helper' class TestBindIntegration < LDAPIntegrationTestCase - INTEGRATION_HOSTNAME = 'ldap.example.org'.freeze def test_bind_success @@ -28,7 +27,7 @@ def test_bind_anonymous_fail assert_equal Net::LDAP::ResultCodeUnwillingToPerform, result.code assert_equal Net::LDAP::ResultStrings[Net::LDAP::ResultCodeUnwillingToPerform], result.message assert_equal "unauthenticated bind (DN with no password) disallowed", - result.error_message + result.error_message assert_equal "", result.matched_dn end @@ -75,7 +74,7 @@ def test_bind_tls_with_bad_hostname_verify_peer_ca_fails ca_file: CA_FILE }, ) error = assert_raise Net::LDAP::Error, - Net::LDAP::ConnectionRefusedError do + Errno::ECONNREFUSED do @ldap.bind BIND_CREDS end assert_equal( @@ -91,7 +90,7 @@ def test_bind_tls_with_bad_hostname_ca_default_opt_merge_fails tls_options: TLS_OPTS.merge(ca_file: CA_FILE), ) error = assert_raise Net::LDAP::Error, - Net::LDAP::ConnectionRefusedError do + Errno::ECONNREFUSED do @ldap.bind BIND_CREDS end assert_equal( @@ -107,7 +106,7 @@ def test_bind_tls_with_bad_hostname_ca_no_opt_merge_fails tls_options: { ca_file: CA_FILE }, ) error = assert_raise Net::LDAP::Error, - Net::LDAP::ConnectionRefusedError do + Errno::ECONNREFUSED do @ldap.bind BIND_CREDS end assert_equal( @@ -142,7 +141,7 @@ def test_bind_tls_with_bogus_hostname_system_ca_fails @ldap.host = '127.0.0.1' @ldap.encryption(method: :start_tls, tls_options: {}) error = assert_raise Net::LDAP::Error, - Net::LDAP::ConnectionRefusedError do + Errno::ECONNREFUSED do @ldap.bind BIND_CREDS end assert_equal( diff --git a/test/test_ldap_connection.rb b/test/test_ldap_connection.rb index 5374c591..c7f4f1ec 100644 --- a/test/test_ldap_connection.rb +++ b/test/test_ldap_connection.rb @@ -61,7 +61,7 @@ def test_result_for_connection_failed_is_set ldap_client = Net::LDAP.new(host: '127.0.0.1', port: 12345) - assert_raise Net::LDAP::ConnectionRefusedError do + assert_raise Errno::ECONNREFUSED do ldap_client.bind(method: :simple, username: 'asdf', password: 'asdf') end @@ -86,11 +86,10 @@ def test_blocked_port def test_connection_refused connection = Net::LDAP::Connection.new(:host => "fail.Errno::ECONNREFUSED", :port => 636, :socket_class => FakeTCPSocket) stderr = capture_stderr do - assert_raise Net::LDAP::ConnectionRefusedError do + assert_raise Errno::ECONNREFUSED do connection.socket end end - assert_equal("Deprecation warning: Net::LDAP::ConnectionRefused will be deprecated. Use Errno::ECONNREFUSED instead.\n", stderr) end def test_connection_timeout