From d3ad8df7e075c553e492c9a0f6b8203153aeaee7 Mon Sep 17 00:00:00 2001
From: Tawan Sierek <tawan.sierek@gmail.com>
Date: Fri, 16 Oct 2015 22:33:15 +0200
Subject: [PATCH] Fix warnings triggered by raise_error matcher

Fix warnings that are triggered when the `raise_error` matcher
is used without providing a specific error class or message.

The warning quoted:
>WARNING: Using the `raise_error` matcher without providing a specific error or
>message risks false positives, since `raise_error` will match when Ruby raises
>a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the
>expectation to pass without even executing the method you are intending to
>call. Instead consider providing a specific error class or message. This
>message can be supressed by setting:
>`RSpec::Expectations.configuration.warn_about_potential_false_positives =
>false`.
---
 spec/shoryuken/middleware/server/auto_delete_spec.rb          | 4 ++--
 .../middleware/server/exponential_backoff_retry_spec.rb       | 4 ++--
 spec/shoryuken/middleware/server/timing_spec.rb               | 4 ++--
 spec/shoryuken/processor_spec.rb                              | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/spec/shoryuken/middleware/server/auto_delete_spec.rb b/spec/shoryuken/middleware/server/auto_delete_spec.rb
index a72514f4..c2c01326 100644
--- a/spec/shoryuken/middleware/server/auto_delete_spec.rb
+++ b/spec/shoryuken/middleware/server/auto_delete_spec.rb
@@ -55,8 +55,8 @@ def build_message
       expect(sqs_queue).to_not receive(:delete_messages)
 
       expect {
-        subject.call(TestWorker.new, queue, sqs_msg, sqs_msg.body) { raise }
-      }.to raise_error
+        subject.call(TestWorker.new, queue, sqs_msg, sqs_msg.body) { raise "Error" }
+      }.to raise_error(RuntimeError, "Error")
     end
   end
 end
diff --git a/spec/shoryuken/middleware/server/exponential_backoff_retry_spec.rb b/spec/shoryuken/middleware/server/exponential_backoff_retry_spec.rb
index 377d9e31..156d1dac 100755
--- a/spec/shoryuken/middleware/server/exponential_backoff_retry_spec.rb
+++ b/spec/shoryuken/middleware/server/exponential_backoff_retry_spec.rb
@@ -25,7 +25,7 @@
     it 'does not retry the job by default' do
       expect(sqs_msg).not_to receive(:change_visibility)
 
-      expect { subject.call(TestWorker.new, queue, sqs_msg, sqs_msg.body) { raise } }.to raise_error
+      expect { subject.call(TestWorker.new, queue, sqs_msg, sqs_msg.body) { raise "Error" } }.to raise_error(RuntimeError, "Error")
     end
 
     it 'does not retry the job if :retry_intervals is empty' do
@@ -33,7 +33,7 @@
 
       expect(sqs_msg).not_to receive(:change_visibility)
 
-      expect { subject.call(TestWorker.new, queue, sqs_msg, sqs_msg.body) { raise } }.to raise_error
+      expect { subject.call(TestWorker.new, queue, sqs_msg, sqs_msg.body) { raise "Error" } }.to raise_error(RuntimeError, "Error")
     end
 
     it 'retries the job if :retry_intervals is non-empty' do
diff --git a/spec/shoryuken/middleware/server/timing_spec.rb b/spec/shoryuken/middleware/server/timing_spec.rb
index edca3773..773bc7e5 100644
--- a/spec/shoryuken/middleware/server/timing_spec.rb
+++ b/spec/shoryuken/middleware/server/timing_spec.rb
@@ -54,8 +54,8 @@
       end
 
       expect {
-        subject.call(TestWorker.new, queue, sqs_msg, sqs_msg.body) { raise }
-      }.to raise_error
+        subject.call(TestWorker.new, queue, sqs_msg, sqs_msg.body) { raise "Error" }
+      }.to raise_error(RuntimeError, "Error")
     end
   end
 end
diff --git a/spec/shoryuken/processor_spec.rb b/spec/shoryuken/processor_spec.rb
index 35887c2c..f34051b6 100644
--- a/spec/shoryuken/processor_spec.rb
+++ b/spec/shoryuken/processor_spec.rb
@@ -299,7 +299,7 @@ def perform(sqs_msg, body); end
       it 'does not extend the message invisibility' do
         expect(sqs_msg).to receive(:visibility_timeout=).never
         expect_any_instance_of(TestWorker).to receive(:perform).and_raise 'worker failed'
-        expect { subject.process(queue, sqs_msg) }.to raise_error
+        expect { subject.process(queue, sqs_msg) }.to raise_error(RuntimeError, "worker failed")
       end
     end
   end