Remove dead code and ineffective optimization path form VpDivd #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only speeds up about 3% in the best case. About 99.98% case running the test, it won't enter to this optimization path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove optimization path for
c->frac[i] == 1 AND first two DECDIGs of divisor and remainder is the samecondition.I think it's worth erasing from the view of maintaining because the condition to enter this optimization path is too strict. (0.02% of the division executed in test).
Remove unused carry logic in VpDivd
It is never needed in test. Never needed in 100million random division experiment(with BASE_FIG=2 to cover many corner cases)
Carry only needs when
c->frac[i]is wrongly calculated to0, but it never happens because VpDivd strictly comparesb->frac[i=0...b_prec]withr->frac[ind_c+i]