Skip to content

Commit

Permalink
catch up ruby 3.4.0 error related changes
Browse files Browse the repository at this point in the history
* should use `base_label` instead of `label`.
* should accept both backtick or single quote
* shoudl accept with class name
  • Loading branch information
ko1 committed Feb 20, 2024
1 parent 69909a3 commit 9c389d9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions lib/debug/thread_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ def wait_next_action_
true
else
true if depth >= DEBUGGER__.frame_depth - 3 &&
caller_locations(2, 1).first.label == target_location_label
caller_locations(2, 1).first.base_label == target_location_label
# TODO: imcomplete condition
end
end
Expand All @@ -1005,7 +1005,7 @@ def wait_next_action_
true if pat === tp.callee_id.to_s
else # :return, :b_return
true if depth >= DEBUGGER__.frame_depth - 3 &&
caller_locations(2, 1).first.label == target_location_label
caller_locations(2, 1).first.base_label == target_location_label
# TODO: imcomplete condition
end
end
Expand Down
4 changes: 2 additions & 2 deletions test/protocol/boot_config_raw_dap_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def test_boot_configuration_works_correctly
threads: [
{
id: 1,
name: "#1 #{temp_file_path}:1:in `<main>'"
name: /\#1 #{temp_file_path}:1:in [`']<main>'/
}
]
}
Expand All @@ -141,7 +141,7 @@ def test_boot_configuration_works_correctly
threads: [
{
id: 1,
name: "#1 #{temp_file_path}:1:in `<main>'"
name: /\#1 #{temp_file_path}:1:in [`']<main>'/
}
]
}
Expand Down
4 changes: 2 additions & 2 deletions test/protocol/threads_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ def test_reponse_returns_correct_threads_info

assert_threads_result(
[
/\.rb:\d:in `<main>'/,
/\.rb:\d:in `block in foo'/
/\.rb:\d:in [`']<main>'/,
/\.rb:\d:in [`']block in (Object#)?foo'/
]
)

Expand Down

0 comments on commit 9c389d9

Please sign in to comment.