Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path option to breakpoints #405

Merged
merged 9 commits into from
Dec 1, 2021
Merged

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Nov 21, 2021

After a discussion with @ko1, we decided to add path: option to breakpoint points. Specifically, they are:

  • MethodBreakpoint - e.g. break Class#method path: path_pattern
  • CheckBreakpoint - e.g. break if: a == 1 path: path_pattern
  • CatchBreakpoint - e.g. catch Exception path: path_pattern
  • WatchBreakpoint - e.g. watch @ivar path: path_pattern

When path: is provided, the breakpoint will only stop when all the conditions are fulfilled + the event that triggers it (method call, raised exception...etc.) happens at the path that matches the option.

@st0012 st0012 force-pushed the breakpoint-path-option branch 2 times, most recently from cb9b3ff to fcfa180 Compare November 22, 2021 11:05
@st0012 st0012 requested a review from ko1 November 26, 2021 10:56
@ko1 ko1 merged commit 0d4945c into ruby:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants