Avoid calling @sock.close
for CDP tests
#565
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sock
is only defined when running DAP tests:debug/test/support/protocol_utils.rb
Lines 327 to 328 in 049db87
Therefore,
@sock
will benil
when finishing CDP tests and causeNoMethodError
.And we haven't seen errors because DAP tests are always ran before CDP's. So the
@sock
variable will be left assigned. If we usedap: false
in any protocol test, we can see the error: