Alias Session send methods #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods ``respond``, ``respond_fail`` and ``fire_event`` can be aliased to ``send_response``, ``send_fail_response`` and ``send_event``, respectively.
Maumagnaguagno
changed the title
ono-max
reviewed
Mar 8, 2023
lib/debug/server_dap.rb
Outdated
| def respond req, res | ||
| send_response(req, **res) | ||
| end | ||
| alias respond send_response |
There was a problem hiding this comment.
I cannot accept this change because this change breaks existing codes.
def send_response(req, **res)
puts req, res
end
# def respond req, res
# send_response(req, **res)
# end
alias respond send_response
def send_response(req, **res)
puts req, res
end
respond({}, {a: 1}) # => wrong number of arguments (given 2, expected 1) (ArgumentError)There was a problem hiding this comment.
Sorry, about that.
I wanted to test if this alias was ok, since it was similar enough to the other modifications.
I removed the offending commit.
There was a problem hiding this comment.
No problem. Thank you for your contribution 👍
ono-max
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods
respond,respond_failandfire_eventcan be aliased tosend_response,send_fail_responseandsend_event, respectively.Related to #890.