Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate truffleruby failure by using unreleased stringio gem #790

Closed
wants to merge 1 commit into from

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Nov 27, 2023

The fix has been merged but not released yet: ruby/stringio#71

@eregon
Copy link
Member

eregon commented Nov 28, 2023

Shouldn't be necessary anymore (stringio 3.1.0 was released)

@st0012 st0012 force-pushed the mitigate-truffleruby-failure branch from f495997 to 46df4f2 Compare November 28, 2023 10:48
@eregon
Copy link
Member

eregon commented Nov 28, 2023

But unfortunately there seems to be some not updated cache or so yet in rubygems.org :/
ruby/stringio#71 (comment)

@eregon
Copy link
Member

eregon commented Nov 28, 2023

The failure on https://github.com/ruby/irb/actions/runs/7017641177/job/19091354167?pr=790#step:3:87 is due to the debug gem using RBASIC()->flags too.
I'll make a PR.

@eregon
Copy link
Member

eregon commented Nov 28, 2023

ruby/debug#1039

@st0012 st0012 closed this Dec 1, 2023
@st0012
Copy link
Member Author

st0012 commented Dec 1, 2023

@eregon Thanks for the context and the PR on debug 🙏
Since the goal is to test compilation against TruffleRuby directly in debug repo, I added #796 to skip installing debug with TruffleRuby in IRB.

@st0012 st0012 deleted the mitigate-truffleruby-failure branch December 1, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants