start at compiling ruby-openssl with openssl 3.0.0 beta1 #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… key might not be populated. Check for this and raise an error rather than core dump
| @@ -399,6 +399,10 @@ ossl_pkey_check_public_key(const EVP_PKEY *pkey) | |||
|
|
|||
| /* OpenSSL < 1.1.0 takes non-const pointer */ | |||
| ptr = EVP_PKEY_get0((EVP_PKEY *)pkey); | |||
| if(ptr == NULL) { | |||
There was a problem hiding this comment.
Pardon this style note: Other if statements are following by a space character in this file. I don't know the preferred form, just noted this being slightly different from the other if conditionals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a few things in openssl-missing.h so that we do not get duplicate macro errors.
After that, there are many dozen deprecation warnings, but it does compile.
We have ~5 years to remove all those deprecation warnings, but I've done one in this pull request.
Testing of this effort show failures in the test cases, which are being reviewed.