Use the released version of strscan on lobsters and shipit #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwstauner
approved these changes
Nov 4, 2025
Member
Author
|
I realized it wasn't an obsolete method, so I fixed the upstream instead ruby/strscan#169. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby/strscan#168 broke lobsters and shipit https://github.com/ruby/ruby/actions/runs/19080798257/job/54508537191. The latest tzinfo.gem still uses the method removed in the PR.
Until we fix it on tzinfo or revert the strscan change, I want to switch to a released strscan to avoid failing the ZJIT ruby-bench CI in the meantime.