Skip to content

Conversation

@ntkme
Copy link
Contributor

@ntkme ntkme commented May 16, 2025

What was the end-user or developer problem that led to this PR?

Remove the setup-ruby workaround as upstream change has been merged: ruby/setup-ruby#762

What is your fix for the problem, implemented in this PR?

Update ruby/setup-ruby to v1.240.0

Make sure the following tasks are checked

@ntkme
Copy link
Contributor Author

ntkme commented May 16, 2025

@deivid-rodriguez

@ntkme
Copy link
Contributor Author

ntkme commented May 16, 2025

There are a few test failures:

Expected make command "make  clean", but was "make DESTDIR\= clean"

Does not seem to be critical, but probably need to take a look at why.

@ntkme
Copy link
Contributor Author

ntkme commented May 16, 2025

Looks like there is issue with my setup-ruby change that MAKE's value somehow has an extra space like make at the end.

@ntkme
Copy link
Contributor Author

ntkme commented May 16, 2025

ruby/setup-ruby#765

@ntkme ntkme marked this pull request as draft May 16, 2025 18:13
@deivid-rodriguez
Copy link
Contributor

Thanks for looking into it!

@ntkme ntkme changed the title Bump ruby/setup-ruby from 1.238.0 to 1.240.0 Bump ruby/setup-ruby from 1.238.0 to 1.241.0 May 16, 2025
@ntkme ntkme marked this pull request as ready for review May 16, 2025 19:36
@deivid-rodriguez
Copy link
Contributor

Thank you @ntkme!

@deivid-rodriguez deivid-rodriguez merged commit fc797ca into ruby:master May 16, 2025
92 checks passed
@ntkme ntkme deleted the update-setup-ruby branch May 16, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants