Switch cache_all to be true by default
#8975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make it a standard setting.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/cache-all-by-default
branch
from
3bbb6cd to
17e356f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Make sure to consolidate all setting toggles that we consider breaking changes.
What is your fix for the problem, implemented in this PR?
I removed the feature flag and made it a setting that's
trueby default. I could've completely removed the setting but I kept it for now just in case the default value oftruecauses any issues, so people can workaround.Closes #8656.
We could completely remove the setting later if we deem it unnecessary.
Make sure the following tasks are checked