Resurrect a method that has not been obsolete #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially revert ruby#168 because strscan_rest_p did not have rb_warning("StringScanner#rest? is obsolete"). It is actively used by the latest tzinfo.gem, and we shouldn't remove it without deprecating it.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 4, 2025
(ruby/strscan#169) Partially revert ruby/strscan#168 because strscan_rest_p did not have `rb_warning("StringScanner#rest? is obsolete")`. It is actively used by the latest tzinfo.gem, and we shouldn't remove it without deprecating it. ruby/strscan@f3fdf21189
This was referenced Nov 4, 2025
Member
|
That method is documented as obsolete since a6c2a8e at 2004-02-18. |
Member
Member
|
How about adding explicit |
Member
Author
|
Yeah, that's my point. I'm suggesting to ship a release with |
jacob-shops
pushed a commit
to Shopify/ruby
that referenced
this pull request
Nov 12, 2025
(ruby/strscan#169) Partially revert ruby/strscan#168 because strscan_rest_p did not have `rb_warning("StringScanner#rest? is obsolete")`. It is actively used by the latest tzinfo.gem, and we shouldn't remove it without deprecating it. ruby/strscan@f3fdf21189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert #168 because strscan_rest_p did not have
rb_warning("StringScanner#rest? is obsolete").It is actively used by the latest tzinfo.gem, and we shouldn't remove it without deprecating it.