From a4d983d6acfd035240c849ff11762c2c256dc717 Mon Sep 17 00:00:00 2001 From: Yuri Bocharov Date: Sat, 6 Jul 2024 13:56:04 -0400 Subject: [PATCH] fix: flaky case_contact index (#5885) Potentially unflakes the test. My theory is that sometimes the draft would appear before the real test because both were using Time.zone.today for the time. I hardcoded more values to improve consistency. --- spec/system/case_contacts/index_spec.rb | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/spec/system/case_contacts/index_spec.rb b/spec/system/case_contacts/index_spec.rb index 6eb85d8927..d1d77b1781 100644 --- a/spec/system/case_contacts/index_spec.rb +++ b/spec/system/case_contacts/index_spec.rb @@ -12,10 +12,11 @@ context "without filter" do let(:case_contacts) do [ - create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: Time.zone.yesterday - 1), - create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: Time.zone.yesterday), - create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: Time.zone.today), - create(:case_contact, :started_status, creator: volunteer, casa_case: casa_case, occurred_at: Time.zone.today, + create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: 2.days.ago), + create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: 1.days.ago), + create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: Time.zone.now, + contact_types: [create(:contact_type, name: "Most Recent Case Contact")]), + create(:case_contact, :started_status, creator: volunteer, casa_case: casa_case, occurred_at: 3.days.ago, contact_types: [create(:contact_type, name: "DRAFT Case Contact")]) ] end @@ -56,9 +57,8 @@ case_contacts sign_in volunteer visit case_contacts_path - within(".card-title", match: :first) do - expect(page).to have_text(case_contacts[2].contact_groups_with_types.keys.first) - end + expect(page).to have_text("Most Recent Case Contact") + expect(page).to have_text("DRAFT Case Contact") end end