Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix superuser dashboard recently added users #3473

Closed
2 tasks
cielf opened this issue Mar 19, 2023 · 5 comments · Fixed by #3529
Closed
2 tasks

Fix superuser dashboard recently added users #3473

cielf opened this issue Mar 19, 2023 · 5 comments · Fixed by #3529
Assignees
Labels
Help Wanted Groomed + open to all!

Comments

@cielf
Copy link
Collaborator

cielf commented Mar 19, 2023

Summary

Make the superuser dashboard "recently added users" actually useful!

Why

Right now it's screen space that is pretty much totally wasted - not informative and no utility

Details

1/ Add the email to the text. We have so many "Name Not Provided" that it's a bit ridiculous.
2/ Change the link to edit rather than show. (We have no user show in the controller, and, really, the superuser is not going to be signing in unless there's something that needs to be done!)
3/ Limit the view to the 20 most recent users

Criteria for completion

  • Functionality as described
  • Tests to support the functionality
@cielf cielf added the Help Wanted Groomed + open to all! label Mar 19, 2023
@Isaac-alencar
Copy link
Contributor

Hey, I would like to work on it!

@dorner
Copy link
Collaborator

dorner commented Mar 22, 2023

Go for it!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

This issue has been inactive for 245 hours (10.21 days) and will be automatically unassigned after 115 more hours (4.79 days).

@Isaac-alencar
Copy link
Contributor

Hi, I didn't have time to work on this issue lately, but I started to work on it today! If the GitHub actions unassign me, could you please give it to me again? Thank you for being patient.

@github-actions
Copy link
Contributor

This issue has been inactive for 251 hours (10.46 days) and will be automatically unassigned after 109 more hours (4.54 days).

dorner pushed a commit that referenced this issue Apr 19, 2023
* add email to the text and change link to edit_user_admin rather than admin_user

* add a limit of 20 to recent users query

* refactor recent_users query

* add specs for recent users on admin dashboard

* add helper to display correct text for a user that does not have a name

* merge three it test cases into a single one to avoid overdoing user creatioon

* removing unnecessary `.presence` method call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Groomed + open to all!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants