Account Requests - Fix Users disappearing on error

[cielf]

Summary

If a super admin is editing an account request and attempts to save it, but there is an error, the user information disappears. This shouldn't happen.

Why fix?

Possible error in re-entering, also slows down the process

Criteria for completion

• [] User information is preserved if there is an error on the account request edit
• [] tests to support this behaviour.

[coalest]

@cielf Can you provide some more information on how to replicate this issue? I don't see an option for admins to edit account requests.

[cielf]

@coalest
On local, from the home page. Click "Register your bank here for free". Click "I am an Essentials Banks..." Fill in a name, email, details and "I'm not a robot", and submit. Wait a couple of minutes for the email to appear in your browser.
Click "Confirm this Request", then "I'm Ready, Let's go!" Wait a couple of minutes for the next email to appear in your browser. Click "Create This Organization". Sign in with the superadmin login

That should take you to a screen where you are editing that particular account request. If you scroll down, you will see a user. Click save without filling in a short name. There will be an error (expected) and the user will be gone (not expected).

[coalest]

@cielf Thanks for the explanation! Can I take this task?

[cielf]

Yup!