Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3593-change-all-occurances-of-forecasting-to-historical-trends #3598

Merged
merged 3 commits into from
May 19, 2023
Merged

3593-change-all-occurances-of-forecasting-to-historical-trends #3598

merged 3 commits into from
May 19, 2023

Conversation

napster235
Copy link
Contributor

@napster235 napster235 commented May 15, 2023

Resolves #3593

Description

Changed all occurances of forecasting to historical trends

How Has This Been Tested?

Updated specs where needed

Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@napster235 one comment - otherwise looks pretty straightforward :)

@@ -96,7 +96,7 @@
</li>
<li class="nav-item <%= 'active' if current_page?(broadcast_announcements_path) %>">
<%= link_to(broadcast_announcements_path, class: "nav-link #{active_class(['broadcast_announcements'])}") do %>
<i class="nav-icon fa fa-circle-o"></i>Partner Announcement
<i class="nav-icon fa fa-circle-o"></i>Partner Annoucement
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it in b73877c

@napster235 napster235 requested a review from dorner May 17, 2023 06:45
@dorner
Copy link
Collaborator

dorner commented May 19, 2023

@napster235 thanks very much for your help!

@dorner dorner merged commit 052ba77 into rubyforgood:main May 19, 2023
@napster235
Copy link
Contributor Author

@dorner My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forecasting --change to Historical Trends
2 participants