Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] #3684 filter says by item category, but it looks like by item to me. #3698

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

Kernapillar
Copy link
Contributor

@Kernapillar Kernapillar commented Jun 28, 2023

Resolves #3684
I updated the "filter by item category" to be "filter by item" in the in the index file under storage locations.
I don't think I need to update any tests for this issue

Excited to join the team!

@Kernapillar Kernapillar reopened this Jun 28, 2023
@dorner
Copy link
Collaborator

dorner commented Jun 28, 2023

Nice - thanks for the contribution!

@dorner dorner merged commit b2caa57 into rubyforgood:main Jun 28, 2023
@Kernapillar Kernapillar deleted the kernapillar/#3684 branch June 29, 2023 16:23
@cielf
Copy link
Collaborator

cielf commented Jul 10, 2023

Thanks @Kernapillar -- we pushed this to production this morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage items -- filter says by item category, but it looks like by item to me.
3 participants