Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4516 fix child requests for inactive children #4699

Conversation

SansSeryph
Copy link
Contributor

Resolves #4516

Description

When building the query in build_family_requests_attributes, only active children were getting selected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  1. Create a new child item request
  2. Ensure that at least one inactive child is selected
  3. Submit the item request
  4. Verify that all children that are inactive but were selected has an items on their detail page

@cielf cielf requested review from dorner and cielf October 2, 2024 16:29
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does what I expect it to! (so LGTM) over to @dorner for a technical check.

@dorner
Copy link
Collaborator

dorner commented Oct 6, 2024

All good here!

@dorner dorner merged commit 8097b9b into rubyforgood:main Oct 6, 2024
11 checks passed
Copy link
Contributor

@SansSeryph: Your PR 4516 fix child requests for inactive children is part of today's Human Essentials production release: 2024.10.13.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Issue with selecting children for request who are not currently active
3 participants